Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add guide for timestamping #407

Merged
merged 12 commits into from
Sep 3, 2024
Merged

doc: add guide for timestamping #407

merged 12 commits into from
Sep 3, 2024

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Aug 28, 2024 •
edited
Loading

Resolve: #404

Signed-off-by: Yi Zha [email protected]

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit b62b0e4
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/66d19a5acc12080008c94cac
😎 Deploy Preview https://deploy-preview-407--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yizha1 added 3 commits August 29, 2024 15:02
@yizha1
update
7d4f6d6 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
update
2f790de 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
update
e3a1070 
Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 marked this pull request as ready for review August 29, 2024 07:29
Two-Hearts
Two-Hearts reviewed Aug 29, 2024
View reviewed changes
Two-Hearts
Two-Hearts reviewed Aug 29, 2024
View reviewed changes
Copy link

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's replace using trusted timestamps with with timestamping.

@yizha1
update per comments
14cbf4d 
Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 requested a review from Two-Hearts August 29, 2024 08:01
yizha1 added 2 commits August 29, 2024 16:08
@yizha1
update per comments
06d9d3f 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
update
f259933 
Signed-off-by: Yi Zha <[email protected]>
Two-Hearts
Two-Hearts reviewed Aug 29, 2024
View reviewed changes
@FeynmanZhou FeynmanZhou mentioned this pull request Aug 29, 2024
Merged
@yizha1
update
4d24685 
Signed-off-by: Yi Zha <[email protected]>
Two-Hearts
Two-Hearts approved these changes Aug 29, 2024
View reviewed changes
Copy link

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 changed the base branch from v1-2 to main August 29, 2024 09:22
FeynmanZhou
FeynmanZhou previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also reviewed the preview page https://deploy-preview-407--notarydev.netlify.app/docs/user-guides/how-to/timestamping/

JeyJeyGao
JeyJeyGao approved these changes Aug 30, 2024
View reviewed changes
Copy link

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IANAM

FeynmanZhou
FeynmanZhou previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1
update
0c03690 
Signed-off-by: Yi Zha <[email protected]>
yizha1 added 2 commits August 30, 2024 18:07
@yizha1
fix the highlight
7874c9d 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
update
b62b0e4 
Signed-off-by: Yi Zha <[email protected]>
FeynmanZhou
FeynmanZhou approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 approved these changes Sep 3, 2024
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 89b21b1 into notaryproject:main Sep 3, 2024
5 checks passed
@yizha1 yizha1 deleted the doc-timestamping branch September 3, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a how-to document for timestamping feature
6 participants
@yizha1 @shizhMSFT @FeynmanZhou @JeyJeyGao @vaninrao10 @Two-Hearts