added troubleshooting to fix #275 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zr-msft
requested review from
FeynmanZhou,
NiazFK,
iamsamirzon,
justincormack,
priteshbandi,
SteveLasker,
toddysm,
vaninrao10 and
yizha1
as code owners
✅ Deploy Preview for notarydev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FeynmanZhou
previously approved these changes
Jun 14, 2023
|
@iamsamirzon @priteshbandi would you mind take a look at this PR? |
iamsamirzon
previously approved these changes
Jun 19, 2023
Two-Hearts
reviewed
Jun 20, 2023
Two-Hearts
reviewed
Jun 20, 2023
There was a problem hiding this comment.
@zr-msft Could you also address issues mentioned in issue 291? Thanks. /cc: @yizha1 @FeynmanZhou
zr-msft
dismissed stale reviews from iamsamirzon, yizha1, and FeynmanZhou
via
dea7ac0
|
@Two-Hearts I feel that #291 is out of scope for this PR and should be handled separately. Per this, it seems that @Roseline-Bassey is already working on it: #291 (comment) |
Signed-off-by: Zach Rhoads <[email protected]>
|
thanks @priteshbandi I incorporated most of your fixes and left some wording as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #275
workaround for