Freeze when "Select Active Targets" #447

d-xo · 2016-06-19T15:48:22Z

Description

Atom freezes whenever I press cmd-alt-t or select Select Active Targets in the command palette.

I am on Atom 1.8.0 (OS X 10.11.5), and Build is the only enabled plugin.

I am using the Genesis theme (https://atom.io/themes/genesis-ui).

The Genesis theme works fine with all my other plugins.
(if it is a problem in the theme, please let me know and I will file a bug in the appropriate project)

Steps

Launch atom
Press cmd-alt-t

Outcome

Atom is frozen

Recording

The text was updated successfully, but these errors were encountered:

noseglid · 2016-06-19T17:55:41Z

Do you get a crash report or anything actionable? Do you have any reason to suspect it's because of the genesis theme?
I'm not sure what to do with this report. It's not crashing for me, I have the exact same setup.

d-xo · 2016-06-19T19:58:42Z

@noseglid feeling pretty silly now, am also no longer able to reproduce the issue.

Closed, sorry for taking up your time :/

ndugger · 2016-06-21T02:09:58Z

I'm actually experiencing this issue right now on Windows 10.

My atom is up to date, the build package is up to date... I'm not sure what's happening.

icidasset · 2016-06-21T10:02:49Z

I have the same issue, no idea where it's coming from and no crash reports (haven't waited longer than 5 minutes though).

noseglid · 2016-06-21T10:25:37Z

When did it start to happen? What have changed? Does a restart solve it? Reinstall?

icidasset · 2016-06-21T10:36:59Z

@noseglid I just installed it, along with the build-stack package. Restarting atom and reinstalling the package doesn't fix it. Also tried to disable the build-stack package, no changes. Tried to use the dev-tools to find the problem, but that freezes too. Anything else I could try?

noseglid · 2016-06-21T10:40:05Z

I'm guessing somethings ends up in an infinite loop. That's normally what happens when everything freezes. Is (at least) 1 CPU running at 100% when it's frozen?

If so, this could be a way to debug further: https://www.joyent.com/blog/mdb-and-node-js. I have never used it for nodejs, unfortunately but something like that is the only way forward I can think of at least.

icidasset · 2016-06-21T10:43:28Z

Yup.

I will try to look into that mdb thing.

noseglid · 2016-06-21T10:43:55Z

Cool! Let me know if there's anything I can do to help from here. I think the ::jsstack command would probably shed a big chunk of light over the problem.

ndugger · 2016-06-21T15:40:36Z

For me, It's a new computer. I installed atom, installed the atom-build package, and hit [ctrl]+[alt]+[t] in order to open the targets list.

So everything is a fresh install on my side of things. Not sure if I'm missing an unknown dependency somehow. I'll look at it more when I get home.

ndugger · 2016-06-21T23:11:37Z

Uninstalled/reinstalled atom and the atom-build package. I have no other packages installed at this time.

I've looked through the windows event viewer, watched the resource monitor, and I can't seem to figure out what's causing it to freeze up. It won't even open the target menu; it just sits there and does nothing.

simonknittel · 2016-06-24T13:00:05Z

I'm experiencing something similar.

I have two projects with the same gulpfile.babel.js. In one of the project Atoms freezes when I select "Select Active Targets". The only difference between the two projects is, that in the project, where it freezes the gulpfile.babel.js is located in a subdirectory of the project. I'm on OS X 10.11 with Atom 1.8

Project 1 (works fine)

root
- gulpfile.babel.js
- package.json
- ...

Project 2 (freezes)

root
- subdirectory
  - gulpfile.babel.js
  - package.json
  - ...

noseglid · 2016-06-25T20:57:15Z

@simonknittel Could possibly be because it's completely lacking a build file. I'll try and review the code to see if there could be any races or something similar there. Thanks for info.

black-snow · 2016-07-22T21:49:51Z

Same issue here, OS X, atom 1.8 (for more spec see).

Project's files are within a subdirectory plus it has two package.json. Feels like that's the issue (for it didn't hang on other projects).

smonetti · 2016-08-11T14:33:44Z

In my case, it's because I was missing .atom-build.yml, in the project root. When I put that back in there it worked.

noseglid · 2016-08-12T07:48:46Z

@smonetti Thanks for the input. It shouldn't freeze even if there is no .atom-build* file, but as a workaround it's good until we have this sorted out.

oddman621 · 2016-08-30T15:51:17Z

Same issue here. When I press F7(Ctrl+Alt+T) with Makefile, it freezes. I'm using Linux environment. My cpu is dualcore, when freezes after pressed F7, CPU usage goes about 50%.

omeryagmurlu · 2016-09-17T21:11:28Z

Same here on Linux. Atom 1.10.2

noseglid · 2016-09-18T06:34:49Z

So many with this issue now... Anyone who is able to reproduce care to do
some debugging so we can get it fixed?
On lör 17 sep. 2016 at 23:11, Ömer Erdinç Yağmurlu [email protected]
wrote:

Same here on Linux.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#447 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4_-KIl6pxbDD1zhLt5JR0KikNWoTluks5qrFeAgaJpZM4I5MP3
.

mr-pascal · 2016-09-19T07:13:46Z

same issue here.
had two projects folders in my Atom.
one where the package.json was
-root

package.json
some folders...

and one where only two .js files (no package.json or similar) were located. removed the second one from my project folders and it works now. Seems like Atom can't handle two projects when one of them is just a simple folder with some .js or so :/

AndiDog · 2016-09-19T07:20:24Z

I didn't debug but can confirm that I have the same situation as @Abszissex: one Atom "project" with multiple folders added to it. Since I have all of my hundred-something repositories in there, I'd like atom-build to only look in the current Git working directory, or only try to search up in the directory structure to the point where a .atom-build.yml is found.

gevial · 2016-10-28T11:24:49Z

Same issue here after upgrading to Atom 1.11 from 1.10.
macOS Sierra
I've tried to remove any .atom-build* files, but no luck.

gevial · 2016-10-28T11:30:20Z

Just moved .atom-build.json from my homedir to the project root and voila! Issue gone.

noseglid · 2016-10-29T08:32:53Z

Interesting...
My top idea so far is that it has something with the file watching to do (to detect changes to the build configurations). Not sure in what way though.

@gevial Does the issue return if you put the .atom-build.json back in your homedir? What about a .atom-build.yml or .atom-build.cson ?

gevial · 2016-10-29T08:57:47Z

@noseglid Strange, now I've moved my .atom-build.yml from project dir to home and still no freezes. Put my previous JSON config to homedir again and still everything's file. Targets are merged from both configs and no freezes at all.

noseglid · 2016-10-29T09:59:03Z

Crappy elusive bug :)
It's surely something intermittent. I wouldn't be surprised if it "just started happening again", without any changes.
Any additional information anyone who has this bug can provide is greatly appreciated. I think that's the only way to narrow it down. A sure way to reproduce would make quick work of this I think.

sarahec · 2016-11-23T18:41:11Z

Same error here on Ubuntu Linux -- Atom freezes on Select Targets. Adding atom-build.yml fixes it, removing atom-build.yml brings the problem back.

jzi040941 · 2016-12-08T12:01:41Z

when my rust project folder is already open, and I did cargo new --myrustproject to make a src , gitignore and something else.
and press ctrl+shift+P to select build target.
Atom is Freeze.
So I reopen the project and selcect build target, then I can build and run. I can see" Hello World."
I thought maybe build package didn't detact the change and project type (such as rust, C#, etc..)
It cause Freeze.
I hope that these comment useful.

ShadowLNC · 2017-01-19T14:35:29Z

Currently experiencing this issue on Windows 10 Pro 64bit, Atom 1.13.0, build 0.67.0 - this may be related to #484.

I believe I have no valid build targets, or at least I haven't added any; I added .atom-build.yml to one of my projects but it's an empty file and I see an error when it tries to parse it (so still no valid build targets). However, the gear icon in the bottom right of my editor shows a check mark and "Refereshing targets for (0.1s)" - regardless of the presence of the aforementioned file - so it clearly believes there is a target (it's a Django project and needs no building).

Calling build:select-active-target (via my remapped F5 key) on my keymap.cson file gives the error "Open file is not part of any open project in Atom". Calling it while in a file that is part of a project will cause the freeze.

Using console logging, I have identified that it calls awaitSelection() from targets-view.js (call originates from target-manager.js:199), but the Promise never resolves (no logging in either the then or catch clauses appeared in the console). After this occurs, 25-30% of my CPU (so a whole core) is in use by an Atom subprocess. No panel is shown, nor any messages about a lack of targets.

SignalWhisperer · 2017-02-06T20:35:56Z

Adding ".atom-build.yml" or ".atom-build.json" did not work for me.

Fresh install of Atom on Linux and the "build" package. Installing the "build-make" package fixed the issue for me.

In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. The fix is to pre-emptively check before the fillTargets call

In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. We don't actually need to call fillTargets as we already know which targets are available, we can just set them ourselves

In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. We have enough information to retrace the steps fillTargets currently takes so we can just set them ourselves

@sphaerophoria

Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447

@sphaerophoria

Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447

noseglid · 2017-05-22T19:38:11Z

Fixed by #520

d-xo closed this as completed Jun 19, 2016

noseglid reopened this Jun 21, 2016

noseglid added the more-info-required label Jun 21, 2016

noseglid mentioned this issue Jul 12, 2016

Build: Select Active Target freezes Editor #457

Closed

noseglid mentioned this issue Jul 22, 2016

editor windows hangs on show targets AtomBuild/atom-build-npm-apm#21

Closed

noseglid added a commit that referenced this issue May 22, 2017

No more recursive loop when there are no targets

560e1b9

Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447

noseglid added a commit that referenced this issue May 22, 2017

No more recursive loop when there are no targets

ad1edd4

Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447

noseglid mentioned this issue May 22, 2017

No recursive loop #520

Merged

noseglid closed this as completed May 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Freeze when "Select Active Targets" #447

Freeze when "Select Active Targets" #447

d-xo commented Jun 19, 2016 •

edited

Loading

noseglid commented Jun 19, 2016 •

edited

Loading

d-xo commented Jun 19, 2016

ndugger commented Jun 21, 2016 •

edited

Loading

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016 •

edited

Loading

ndugger commented Jun 21, 2016

ndugger commented Jun 21, 2016 •

edited

Loading

simonknittel commented Jun 24, 2016 •

edited

Loading

noseglid commented Jun 25, 2016

black-snow commented Jul 22, 2016

smonetti commented Aug 11, 2016

noseglid commented Aug 12, 2016

oddman621 commented Aug 30, 2016

omeryagmurlu commented Sep 17, 2016 •

edited

Loading

noseglid commented Sep 18, 2016

mr-pascal commented Sep 19, 2016

AndiDog commented Sep 19, 2016

gevial commented Oct 28, 2016

gevial commented Oct 28, 2016

noseglid commented Oct 29, 2016

gevial commented Oct 29, 2016

noseglid commented Oct 29, 2016 •

edited

Loading

sarahec commented Nov 23, 2016

jzi040941 commented Dec 8, 2016

ShadowLNC commented Jan 19, 2017 •

edited

Loading

SignalWhisperer commented Feb 6, 2017

noseglid commented May 22, 2017

Freeze when "Select Active Targets" #447

Freeze when "Select Active Targets" #447

Comments

d-xo commented Jun 19, 2016 • edited Loading

Description

Steps

Outcome

Recording

noseglid commented Jun 19, 2016 • edited Loading

d-xo commented Jun 19, 2016

ndugger commented Jun 21, 2016 • edited Loading

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016

icidasset commented Jun 21, 2016

noseglid commented Jun 21, 2016 • edited Loading

ndugger commented Jun 21, 2016

ndugger commented Jun 21, 2016 • edited Loading

simonknittel commented Jun 24, 2016 • edited Loading

noseglid commented Jun 25, 2016

black-snow commented Jul 22, 2016

smonetti commented Aug 11, 2016

noseglid commented Aug 12, 2016

oddman621 commented Aug 30, 2016

omeryagmurlu commented Sep 17, 2016 • edited Loading

noseglid commented Sep 18, 2016

mr-pascal commented Sep 19, 2016

AndiDog commented Sep 19, 2016

gevial commented Oct 28, 2016

gevial commented Oct 28, 2016

noseglid commented Oct 29, 2016

gevial commented Oct 29, 2016

noseglid commented Oct 29, 2016 • edited Loading

sarahec commented Nov 23, 2016

jzi040941 commented Dec 8, 2016

ShadowLNC commented Jan 19, 2017 • edited Loading

SignalWhisperer commented Feb 6, 2017

noseglid commented May 22, 2017

d-xo commented Jun 19, 2016 •

edited

Loading

noseglid commented Jun 19, 2016 •

edited

Loading

ndugger commented Jun 21, 2016 •

edited

Loading

noseglid commented Jun 21, 2016 •

edited

Loading

ndugger commented Jun 21, 2016 •

edited

Loading

simonknittel commented Jun 24, 2016 •

edited

Loading

omeryagmurlu commented Sep 17, 2016 •

edited

Loading

noseglid commented Oct 29, 2016 •

edited

Loading

ShadowLNC commented Jan 19, 2017 •

edited

Loading