Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circleci): linux deployment fix #930

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Conversation

DalderupMaurice
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #930 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #930   +/-   ##
========================================
  Coverage    52.35%   52.35%           
========================================
  Files          236      236           
  Lines         2021     2021           
  Branches       277      277           
========================================
  Hits          1058     1058           
  Misses         796      796           
  Partials       167      167

1 similar comment
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #930 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #930   +/-   ##
========================================
  Coverage    52.35%   52.35%           
========================================
  Files          236      236           
  Lines         2021     2021           
  Branches       277      277           
========================================
  Hits          1058     1058           
  Misses         796      796           
  Partials       167      167

Maurice Dalderup added 2 commits March 15, 2019 17:01
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 15, 2019
@DalderupMaurice DalderupMaurice merged commit a4cb120 into develop Mar 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/ci-linux-fix branch March 15, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant