Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): close tab on middle mouse btn #836

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jan 17, 2019

Description

close tab on middle mouse btn

Motivation and Context

#713

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #713

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #836 into develop will decrease coverage by 0.08%.
The diff coverage is 25%.

@@             Coverage Diff             @@
##           develop     #836      +/-   ##
===========================================
- Coverage    54.37%   54.29%   -0.09%     
===========================================
  Files          227      227              
  Lines         1953     1956       +3     
  Branches       269      270       +1     
===========================================
  Hits          1062     1062              
- Misses         735      737       +2     
- Partials       156      157       +1

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 17, 2019
@DalderupMaurice DalderupMaurice merged commit f562620 into develop Jan 17, 2019
@DalderupMaurice DalderupMaurice deleted the feat/close-middle-btn branch January 17, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on a tab with middle mouse button should close it
1 participant