Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(authLayout): fix unintended scrolling #833

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jan 15, 2019

Description

Fix unintended scrolling

  • side nav was not extended
  • internet tabs etc were scrollable

Motivation and Context

displaced the UI

How Has This Been Tested?

Screenshots (if appropriate)

Before

After

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #747

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #833 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #833   +/-   ##
========================================
  Coverage    54.43%   54.43%           
========================================
  Files          227      227           
  Lines         1951     1951           
  Branches       268      268           
========================================
  Hits          1062     1062           
  Misses         734      734           
  Partials       155      155

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 15, 2019
@DalderupMaurice DalderupMaurice merged commit ce8a75b into develop Jan 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-scroll branch August 2, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI height issue on smaller screens
1 participant