Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(src): added auto-updater #782

Merged
merged 24 commits into from
Jan 12, 2019
Merged

feat(src): added auto-updater #782

merged 24 commits into from
Jan 12, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Dec 23, 2018

Description

  • Added yarnrc to automatically pin deps
  • Added release command for windows/linux
  • Enforced code signing
  • Set publishing source of releasing/auto-updates
  • Added ability for automatic updates (during app startup)
  • Updated splashscreen to match design
  • Fixed error with devtools extension server
  • Removed unused code in settings (regarding the previous way of updating the app)
  • Added repository url to package.json which is needed for electron-builder

Motivation and Context

We need auto updates and code signing 😄

How Has This Been Tested?

All the ways possible

Screenshots (if appropriate)

Screenshot from loading screen update:

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #476
Fixes #720

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #782 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #782   +/-   ##
======================================
  Coverage       54%    54%           
======================================
  Files          225    225           
  Lines         1922   1922           
  Branches       266    266           
======================================
  Hits          1038   1038           
  Misses         730    730           
  Partials       154    154

@DalderupMaurice DalderupMaurice added the PR: don't merge This doesn't seem right label Dec 24, 2018
@DalderupMaurice DalderupMaurice changed the title feat(src): added auto-updater [WIP] feat(src): added auto-updater Jan 6, 2019
@DalderupMaurice DalderupMaurice added PR: needs review Pull request and removed PR: don't merge This doesn't seem right labels Jan 6, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 12, 2019
@DalderupMaurice DalderupMaurice removed the PR: needs review Pull request label Jan 12, 2019
@DalderupMaurice DalderupMaurice merged commit d7f47c8 into develop Jan 12, 2019
@DalderupMaurice DalderupMaurice deleted the feat/auto-updates branch January 12, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-updates Application signing
1 participant