Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tabs): fixed styles & overlaps #753

Merged
merged 10 commits into from
Dec 30, 2018
Merged

Conversation

mhuggins
Copy link
Contributor

@mhuggins mhuggins commented Dec 9, 2018

Description

This fixes the tab styling to:

  1. prevent tabs from overlapping with the window controls, and
  2. prevent tab close button from overlapping with tab label.

Motivation and Context

Because it looks broken and makes clicking buttons non-functional.

How Has This Been Tested?

Opening many tabs, interacting with them, and closing them.

Screenshots (if appropriate)

tab-styles

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #542

@mhuggins mhuggins added the PR: needs review Pull request label Dec 9, 2018
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #753 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #753   +/-   ##
========================================
  Coverage    53.27%   53.27%           
========================================
  Files          207      207           
  Lines         1772     1772           
  Branches       249      249           
========================================
  Hits           944      944           
  Misses         688      688           
  Partials       140      140

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #753 into develop will increase coverage by 0.04%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
+ Coverage     53.4%   53.44%   +0.04%     
===========================================
  Files          207      207              
  Lines         1777     1783       +6     
  Branches       249      249              
===========================================
+ Hits           949      953       +4     
- Misses         689      691       +2     
  Partials       139      139

@mhuggins mhuggins changed the title Chore/tab style chore(tabs): fixed styles & overlaps Dec 9, 2018
@DalderupMaurice
Copy link
Member

DalderupMaurice commented Dec 10, 2018

It still seems to move below the logo and over the buttons 😅
Also, the icons are displayed on top of the tab separation and on top of the X-button/loading indicator

The good part is that it doesn't brake as early as it did before :P Now it only breaks after a shitton of tabs

This is a reference for chrome:

When they hit a certain amount of tabs, they're opened but you cannot see them open up :P It's hidden behind the right shade and it had certain break points where icons are removed and the X-button/loading indicator where hidden

@DalderupMaurice DalderupMaurice added PR: reviewed w/ comments Reviewed but needs to be looked at and removed PR: needs review Pull request labels Dec 10, 2018
@fabric-8
Copy link
Contributor

fabric-8 commented Dec 30, 2018

@mhuggins @DalderupMaurice Hey guys gave it a stab and tried to improve the appearance once tabs get very narrow. What I basically did:

tabs

  • tabs have a min-width
  • close-icon will overlay the favicon so that it's always visible/closable
  • paddings are now equal which makes things look a bit more consistent overall IMO, esp. when dealing with small tabs

What would be nice: Adding a conditional class to the close icon once the tab is smaller than 50px: We could then hide the close icon and only show it when the user hovers the tab.

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: reviewed w/ comments Reviewed but needs to be looked at labels Dec 30, 2018
@DalderupMaurice DalderupMaurice merged commit 597cfb9 into develop Dec 30, 2018
@DalderupMaurice DalderupMaurice deleted the chore/tab-style branch December 30, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening many tabs causes bugs in the UI
3 participants