-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tabs): fixed styles & overlaps #753
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #753 +/- ##
========================================
Coverage 53.27% 53.27%
========================================
Files 207 207
Lines 1772 1772
Branches 249 249
========================================
Hits 944 944
Misses 688 688
Partials 140 140 |
Codecov Report
@@ Coverage Diff @@
## develop #753 +/- ##
===========================================
+ Coverage 53.4% 53.44% +0.04%
===========================================
Files 207 207
Lines 1777 1783 +6
Branches 249 249
===========================================
+ Hits 949 953 +4
- Misses 689 691 +2
Partials 139 139 |
@mhuggins @DalderupMaurice Hey guys gave it a stab and tried to improve the appearance once tabs get very narrow. What I basically did:
What would be nice: Adding a conditional class to the close icon once the tab is smaller than 50px: We could then hide the close icon and only show it when the user hovers the tab. |
Description
This fixes the tab styling to:
Motivation and Context
Because it looks broken and makes clicking buttons non-functional.
How Has This Been Tested?
Opening many tabs, interacting with them, and closing them.
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #542