Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add the ability to import existing seed #1118

Merged
merged 3 commits into from
Aug 25, 2019
Merged

feat(auth): add the ability to import existing seed #1118

merged 3 commits into from
Aug 25, 2019

Conversation

jeroenptrs
Copy link
Contributor

@jeroenptrs jeroenptrs commented Aug 20, 2019 •
edited
Loading

Description

Import existing BIP39 seed

WIP because still need to add copy

Motivation and Context

Must have functionality

How Has This Been Tested?

Imported my keys

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)
    (Potentially a tut on how to do this? 🤷‍♂ )

Closing issues

Fixes #1026

@jeroenptrs jeroenptrs added the PR: needs review Pull request label Aug 20, 2019
@jeroenptrs jeroenptrs added this to the 0.6.0 milestone Aug 20, 2019
@jeroenptrs jeroenptrs self-assigned this Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019 •
edited
Loading

Codecov Report

Merging #1118 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1118   +/-   ##
========================================
  Coverage    50.79%   50.79%           
========================================
  Files          240      240           
  Lines         2063     2063           
  Branches       276      276           
========================================
  Hits          1048     1048           
  Misses         843      843           
  Partials       172      172

@jeroenptrs jeroenptrs changed the title feat(auth): add the ability to import existing seed [WIP] feat(auth): add the ability to import existing seed Aug 20, 2019
@jeroenptrs jeroenptrs added the PR: don't merge This doesn't seem right label Aug 20, 2019
@DalderupMaurice DalderupMaurice removed the PR: don't merge This doesn't seem right label Aug 21, 2019
@DalderupMaurice DalderupMaurice changed the title [WIP] feat(auth): add the ability to import existing seed feat(auth): add the ability to import existing seed Aug 21, 2019
@DalderupMaurice DalderupMaurice added PR: reviewed w/ comments Reviewed but needs to be looked at and removed PR: needs review Pull request labels Aug 21, 2019
@jeroenptrs jeroenptrs force-pushed the feat/import-existing-seed branch from 62db7bb to 76ada46 Compare August 23, 2019 07:31
@jeroenptrs jeroenptrs added PR: needs review Pull request and removed PR: reviewed w/ comments Reviewed but needs to be looked at labels Aug 23, 2019
@jeroenptrs jeroenptrs force-pushed the feat/import-existing-seed branch from 76ada46 to 80cd815 Compare August 23, 2019 07:34
@jeroenptrs jeroenptrs force-pushed the feat/import-existing-seed branch from 8bfebe0 to f10f065 Compare August 25, 2019 09:05
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 25, 2019
@DalderupMaurice DalderupMaurice merged commit 6b698c8 into develop Aug 25, 2019
@DalderupMaurice DalderupMaurice deleted the feat/import-existing-seed branch August 25, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DalderupMaurice DalderupMaurice DalderupMaurice approved these changes

@deanpress deanpress Awaiting requested review from deanpress

Assignees

@jeroenptrs jeroenptrs

Labels
PR: good to merge Reviewed and approved
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Add ability to restore your account from a given mnemonic seed
2 participants
@jeroenptrs @DalderupMaurice