Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): clear claimables balance when signing out or changing wallet #1068

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

DalderupMaurice
Copy link
Member

Description

Clear claimable balances when signing out or changing primary wallets.

Motivation and Context

The old claimable balance was still displayed upon changing accounts/wallets

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #1068 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #1068      +/-   ##
===========================================
- Coverage    50.94%   50.94%   -0.01%     
===========================================
  Files          238      238              
  Lines         2055     2057       +2     
  Branches       274      274              
===========================================
+ Hits          1047     1048       +1     
- Misses         837      838       +1     
  Partials       171      171

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 6, 2019
@DalderupMaurice DalderupMaurice merged commit 0634777 into develop Aug 6, 2019
@DalderupMaurice DalderupMaurice deleted the chore/cleanup-wallets branch August 6, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants