Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected :slug error on valid model, fixes #949 #952

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove unexpected :slug error on valid model, fixes #949 #952

merged 1 commit into from
Sep 11, 2020

Conversation

caiofilipemr
Copy link
Contributor

I believe this simple change solves the issue #949.

@caiofilipemr caiofilipemr changed the title Unexpected :slug error on valid model, fixes #949 Remove unexpected :slug error on valid model, fixes #949 Aug 27, 2020
@parndt
Copy link
Collaborator

parndt commented Aug 27, 2020

Thanks @caiofilipemr that looks like it could do the trick, but CI is failing for this change?

@giovannibonetti
Copy link

Hi, @parndt! I work with @caiofilipemr and we were looking into this together.

but CI is failing for this change?

After taking a closer look it seems like the few cases that failed are not related to these changes at all:

image

Can you run the tests again? It seems like the Coveralls configuration is a bit unstable.

@parndt
Copy link
Collaborator

parndt commented Aug 28, 2020

After taking a closer look it seems like the few cases that failed are not related to these changes at all:

it also reports this failure: https://github.com/norman/friendly_id/pull/952/checks?check_run_id=1036629235#step:10:99

I'll re-run and see. It's failing on Rails 5.0 tests which leads me to believe it's related to Rails 5.

@parndt
Copy link
Collaborator

parndt commented Aug 28, 2020

It seems like the Coveralls configuration is a bit unstable.

Sometimes I wonder if it's even a worthwhile measurement. 😄

@parndt
Copy link
Collaborator

parndt commented Aug 31, 2020

Rather than fight CI, I've opened #954

@parndt
Copy link
Collaborator

parndt commented Aug 31, 2020

@caiofilipemr can you pull in the latest changes to your branch please so that CI may pass?

@parndt parndt merged commit e9a591b into norman:master Sep 11, 2020
@parndt
Copy link
Collaborator

parndt commented Sep 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants