Add more context to RecordNotFound exception #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like, despite rails/rails@d763956 was written 3 years ago, it was only released with Rails v5.0.0.beta1. So that fix would mean not being compatible to Rails prior to v5.x. |
|
Thank you for the PR, I've since merged another PR which also addresses this issue #890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord::RecordNotFoundhas the ability to add more context to the error using three additional parameters:model,primary_keyandid.Using them makes it more easy to analyze the exception and make the application behave in a smarter way (e.g. redirect to another page when objects are deleted from database)
This should fix bug #880.