Fix to_param in ActiveRecord callbacks #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were prompted by the presence of lots of deprecation warnings under Rails 5.1, due to the calls to the `attribute_changed?` method within `to_param`, whose behaviour was expected to change in Rails 5.2. I believe the fix might involve a significant change to `to_param`, so I've also add other tests to comprehensively describe the behaviour of `to_param` in various scenarios where the record succeeded or failed to save. I believe the new callback test also demonstrates a bug in all versions of FriendlyId up to Rails 5.2; the value of the slug used in the callback is the old value. This is a problem if we use that slug to generate a URL as part of behaviour called within that callback.
|
Fantastic! 👍 I ran this against the test suite of https://github.com/refinery/refinerycms as this should have had issues if your code changes something meaningful, and it works fine. |
|
Is it possible we could get a new release with this issue fixed? It was merged seven months ago. |
|
Pushing gem to https://rubygems.org... Thanks for the push @jeremywadsack @lazyatom ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(... and also remove deprecation warnings under Rails 5.1)
I originally started investigating this as part of #816 (see some discussion there about
to_paramfrom the perspective of the deprecation warnings), and also #862 (which features the first version of the callback test I've used here).On the latter, it became clear that there were actually two issues: the deprecation warnings, and the behaviour of
to_paramin callbacks. I decided to write an explicit test for the callback behaviour here, and included a bunch of other tests aboutto_paramin various scenarios.The "fix" basically involves deleting all the dirty tracking code within
to_param, which seems superficially crazy to me, but all the tests pass, so either we don't need that code, or we are missing some key tests around this behaviour.