Split Candidates#each in few methods #773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR splits
Candidates#each
method, thus separating actual yielding from constructing/filtering elements.A minor change, but we can further improve from here: one idea is to create a
Candidate
class, and move slug construction/validation there.Should also solve CodeClimate Issue (https://codeclimate.com/github/norman/friendly_id/FriendlyId::Candidates#complexity)
Main idea is to make this part of code more readable (while keeping simplicity/flexibility)