Configurable Route Generation

[sjaveed]

• friendly_id now takes a routes option which, when set to anything but :friendlyid will generate standard rails style routes when used with e.g. polymorphic_path or form_for etc
• when the routes option isn't specified, it defaults to the current behavior

Given a model:

class Team < ActiveRecord::Base
  friendly_id :name, use: :slugged
end

it generates:

team_path(team)  # returns /team/123-awesome-team-name
team_path(team.id) # returns /team/123
polymorphic_path(team) # returns /team/123-awesome-team-name

With this patch, given a model like:

class Team < ActiveRecord::Base
  friendly_id :name, use: :slugged, routes: :default
end

it generates:

team_path(team) # should return /team/123
team_path(team.friendly_id) # should return /team/123-awesome-team-name
polymorphic_path(team) # should return /team/123

[sjaveed]

@parndt here you go!

[parndt]

I'm a little confused about this line of code and why it's commented out? 😄

[sjaveed]

Good catch :-) I think I'd added it in there before I realized I could leverage the set. Commented it out to test the set and then didn't delete it before committing :-) I'll remove this in the next commit.

[parndt]

@sjaveed that was lightning ⚡ fast.

Could we please have some tests to ensure that we don't regress this behaviour, and a note in the changelog file?

[sjaveed]

@parndt heh thanks :-) I did say I was frustrated :-) Let me see how to test this sucker properly.

[sjaveed]

@parndt updated to fix an issue with the default value of routes and to add tests. Any specific format you'd like me to follow for the Changelog?

[parndt]

For changelog just something simple that links to this PR like in https://github.com/norman/friendly_id/blob/master/Changelog.md#520-not-released-yet

[sjaveed]

@parndt updated the change log as well. Do let me know if you need me to change anything else :-)

[parndt]

Thanks, I merged it as 8531cdc 😄

[sjaveed]

Awesome! Thanks @parndt!