Fixed problem that occurred when module :history was used after :finders #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e :finders. Module finders includes methods from friendly_id_config.finder_methods into base class. But module :history replaces this methods. So, to make :finders and :history works together those methods must be reincluded into base class during initialization of :history. Please, see #717 for problem details.
…estWithFindersBeforeHistory. Test was broken on Travis CI because Name HistoryTestWithFriendlyFindersModuleBeforeHistory::Novelist is too long for sluggable_type.
… FriendlyId::Finders.setup instead of included. Because relation_delegate_class is needed for correct extending of ActiveRecord::AssociationRelation with finder methods.
Maximum version of mysql2 that works with Rails 4.0 is 0.3.10. Maximum version of mysql2 that works with Rails 4.1 is 0.3.13. Older versions are not suppoted by ActiveRecord and couldn't be used for tests on those versions on Rails.
|
looks good to me! |
|
Well. Those changes looks good for 2 contributors. And this PR solves testing problem with |
kimrgrey
added a commit
that referenced
this pull request
Jan 7, 2016
Fixed problem that occurred when module :history was used after :finders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #717.
Module
:findersincludes methods fromfriendly_id_config.finder_methodsinto base class. But module:historyreplaces this methods. So, to make:findersand:historyworks together those methods must be reincluded into base class during initialization of:history.