Fix regenerating slug when regeneration condition overriden (fixes #521) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rman#521) Currently the scope excluding updated object is applied when checking candidates only if slug column is changed. This does not work in case when should_generate_new_friendly_id? is overriden. This commit fixes the problem by always excluding updated object from checking candidates
|
Hey! Any update on the issue? I'd love to see this bug fixed in master, so I can use original repo in my application. I've added support for scoped module. |
|
@arnvald Still waiting for @norman to answer my question at #541 (comment) |
|
@PikachuEXE blame shows 70a6d5a |
|
Closing in favor of #562. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the scope excluding updated object is applied when checking candidates
only if slug column is changed. This does not work in case when
should_generate_new_friendly_id? is overriden. This commit fixes the problem
by always excluding updated object from checking candidates
Here's the issue: #521