Fixes for issues with retrieving agent_config when the server has issues while creating a pvpool #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recheck for agent_config in case it wasn't available Signed-off-by: jackyalbo <[email protected]>
jackyalbo
force-pushed
the
jacky-fixes
branch
from
066e9a2 to
41688e6
Compare
dannyzaken
reviewed
Sep 1, 2020
| res, err := r.NBClient.GetHostsPoolAgentConfigAPI(nb.GetHostsPoolAgentConfigParams{ | ||
| Name: r.BackingStore.Name, | ||
| }) | ||
| if err != nil { |
There was a problem hiding this comment.
not sure it's necessary here, but make sure you don't need to handle different errors in different ways (persistent vs. temp error)
There was a problem hiding this comment.
well I'm currently unaware of any persistent error here. you think about anything specific? thinking about rpc failures that should be temporal - not sure about others... especially when the pool suppose to exist if we got here and it won't be any other type of pool other than hosts
dannyzaken
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for overlooking a missing AGENT_CONFIG in pvpool secret
recheck for agent_config in case it wasn't available
Signed-off-by: jackyalbo [email protected]