Integrated Cloudnative-pg into OLM package #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added Cloudnativ-pg resources in noobaa CSV
- Added cnpg deployment and permissions to CSV InstallStrategy
- Added cnpg CRDs to noobaa owned CRD list
2. olm.go code cleanup
3. Refactored cnpg.go
- Simplified CnpgResources struct by holding one instance for each resource (besides CRDs) instead of holding it in a slice.
- Filter out canned cluster roles that are unnecessary for noobaa.
- limited the scope of the operator to a single namespace
- Reduced unnecessary cnpg operator permissions. Moved most of the cluster rules to a namespace scoped role
- Configured WATCH_NAMESPACE for the operator so it will not watch the entire cluster.
- Added cluster role for non-OLM deployments to allow modifying the admissions webhooks (required by cnpg operator).
Signed-off-by: Danny Zaken <[email protected]>
dannyzaken
requested review from
alphaprinz,
liranmauda,
Neon-White and
jackyalbo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Added Cloudnativ-pg resources in noobaa CSV
olm.go code cleanup
Refactored cnpg.go
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: