Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mount permissions on the agents PV #1356

Merged
merged 1 commit into from
May 8, 2024

Conversation

dannyzaken
Copy link
Member

Explain the changes

  • Fix for mount permissions
    • For some reason, the changes in SCC fixes #1340 caused the PV to be mounted without write permissions for GID 0 and be owned by root user.
    • Added fsGroup 0 to the agent pod. This adds w permission to the mount for the owning GID 0 and provides write access to the agent process.
  • Also moved allowPrivilegeEscalation in the DB sts to the container security context
    • This setting can only be set in the container security context, not the pod security context. (see here)

Issues: Fixed #xxx / Gap #xxx

  1. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2278120

Testing Instructions:

  1. Create a pv pool on an openshift cluster
  2. Make sure it runs successfully
  3. The issue is not reproducible on minikube\rancher, since the pv is mounted there with 777
  • Doc added/updated
  • Tests added

* Added fsGroup 0 to the agent pod
* moved allowPrivilegeEscalation in the DB sts to the container security
  context

Signed-off-by: Danny Zaken <[email protected]>
@dannyzaken dannyzaken requested a review from tangledbytes May 8, 2024 07:20
@dannyzaken dannyzaken mentioned this pull request May 8, 2024
2 tasks
@dannyzaken dannyzaken merged commit 08f0a7b into noobaa:master May 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants