Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding disable_cookies annotation to S3 route #1332

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Adding disable_cookies annotation to S3 route #1332

merged 1 commit into from
Apr 3, 2024

Conversation

jackyalbo
Copy link
Contributor

Explain the changes

  1. Disable the cookies when using s3 routes as some s3 clients like Cyberduck don't handle them correctly.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed S3 route should disable cookies otherwise Cyberduck fails on bad signature #1327

Testing Instructions:

  1. install a noobaa system on top of OCP cluster
  2. try to connect to the system with default access keys using Cyberduck
  3. see that you can connect and list the buckets and not get issues about bad signature
  • Doc added/updated
  • Tests added

liranmauda
liranmauda approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Could you edit the description of this PR and explain the reason?

@jackyalbo
Copy link
Contributor Author

jackyalbo commented Apr 3, 2024 •
edited
Loading

LGTM, Could you edit the description of this PR and explain the reason?

it's already in the description: "some s3 clients like Cyberduck don't handle them correctly." :)
TLDR: Cyberduck

@jackyalbo jackyalbo merged commit 7ef7b69 into noobaa:master Apr 3, 2024
14 checks passed
@jackyalbo jackyalbo deleted the jacky-route-fix branch September 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 route should disable cookies otherwise Cyberduck fails on bad signature
2 participants
@jackyalbo @liranmauda