Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DB Upgrade] Fixing returned status and adding prints #1319

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[DB Upgrade] Fixing returned status and adding prints #1319

merged 1 commit into from
Mar 12, 2024

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Mar 12, 2024 •
edited
Loading

Explain the changes

  1. We returned a wrong state in case the init-container still is running and not yet completed.
    We returned State.String() which didn't just return Running but also printed some more info about the state.
    As we later in the code checks explicitly for Running we should return the correct state
  2. Added prints so we will know for sure what state the HasUpgradeDbContainerFailed function returned.
  3. Added events for the different phases of the upgrade procedure

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo requested a review from dannyzaken March 12, 2024 14:45
@jackyalbo jackyalbo merged commit 489d361 into noobaa:master Mar 12, 2024
13 checks passed
@dannyzaken dannyzaken mentioned this pull request Mar 12, 2024
Merged
2 tasks
@jackyalbo jackyalbo deleted the jacky-try1 branch September 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyalbo @dannyzaken