removed init container for Postgres DB pod #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyalbo
reviewed
Mar 10, 2024
| - name: db | ||
| mountPath: /var/lib/pgsql | ||
| - name: noobaa-postgres-initdb-sh-volume | ||
| mountPath: /init | ||
| containers: |
There was a problem hiding this comment.
Removing all the init containers will result in this code failing as it expects init_containers[0] to exist:
noobaa-operator/pkg/system/phase2_creating.go
Line 1537 in 6ddc25e
dannyzaken
force-pushed
the
danny-fixes
branch
2 times, most recently
from
76c01ce to
6ab46ba
Compare
|
Converted back to draft. Still have some work to do with respect to DB upgrades |
dannyzaken
force-pushed
the
danny-fixes
branch
2 times, most recently
from
bb8bb50 to
5feb1dc
Compare
2 tasks
dannyzaken
force-pushed
the
danny-fixes
branch
3 times, most recently
from
9869af0 to
48504c0
Compare
* The init container was used to workaround an issue with hugepages which seems to be solved. * After removing it, there is no need for privileged container and for DB scc Signed-off-by: Danny Zaken <[email protected]>
jackyalbo
reviewed
Apr 4, 2024
| }, | ||
| ) | ||
| // remove the init conatainer. It was used to workaround a hugepages issue, which was resolved in Postgres | ||
| podSpec.InitContainers = nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: