Fix the GCP CA pool injection flow #1312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben <[email protected]>
dannyzaken
approved these changes
Mar 5, 2024
nimrod-becker
approved these changes
Mar 5, 2024
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Mar 5, 2024
Remove the certificate fix just for GCP as it was causing reflection errors (See noobaa#1312 for more info). Signed-off-by: Ben <[email protected]>
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Mar 5, 2024
Remove the certificate fix just for GCP as it was causing reflection errors (See noobaa#1312 for more info). Signed-off-by: Ben <[email protected]>
Neon-White
added a commit
to Neon-White/noobaa-operator
that referenced
this pull request
Mar 5, 2024
Remove the certificate fix just for GCP as it was causing reflection errors (See noobaa#1312 for more info). Signed-off-by: Ben <[email protected]>
2 tasks
nimrod-becker
pushed a commit
that referenced
this pull request
Mar 5, 2024
Remove the certificate fix just for GCP as it was causing reflection errors (See #1312 for more info). Signed-off-by: Ben <[email protected]>
nimrod-becker
pushed a commit
that referenced
this pull request
Mar 5, 2024
Remove the certificate fix just for GCP as it was causing reflection errors (See #1312 for more info). Signed-off-by: Ben <[email protected]>
|
Closing this since we'll most likely opt to use an entirely different solution that'd make sure Go starts with all the necessary certs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
unsafe.Pointerto access a private, unexported field since reflection cannot access it aloneIssues: Fixed #xxx / Gap #xxx
Testing Instructions: