Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rook to 1.13.1 as part of noobaa operator dependency #1280

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

vh05
Copy link
Contributor

@vh05 vh05 commented Jan 4, 2024

Explain the changes

Updating rook to 1.13.1 to support ocs and making required changed noobaa operator

@vh05 vh05 marked this pull request as draft January 4, 2024 11:18
@vh05 vh05 requested a review from liranmauda January 4, 2024 11:24
@vh05 vh05 changed the title update rook to 1.31.1 update rook to 1.13.1 Jan 4, 2024
@vh05 vh05 changed the title update rook to 1.13.1 update rook to 1.13.1 as part of noobaa operator dependency Jan 4, 2024
@vh05 vh05 requested a review from dannyzaken January 4, 2024 12:16
@vh05
Copy link
Contributor Author

vh05 commented Jan 4, 2024

@umangachapagain Please take a look at this PR

@vh05 vh05 marked this pull request as ready for review January 4, 2024 12:23
Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vh05 vh05 merged commit 05a7f3b into noobaa:master Jan 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants