Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated golangci-lint to 1.55 + removed depracated flags #1276

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

dannyzaken
Copy link
Member

@dannyzaken dannyzaken commented Dec 26, 2023

Explain the changes

  1. updated golangci-lint to latest version - 1.55
  2. removed deprecated flags that produced warning

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken force-pushed the danny-fixes branch 2 times, most recently from 4c67147 to 978f3ac Compare December 26, 2023 15:18
@dannyzaken dannyzaken changed the title updated golangci-lint to 1.55.2 updated golangci-lint to 1.55 + removed depracated flags Dec 26, 2023
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady
Copy link
Contributor

shirady commented Dec 26, 2023

@dannyzaken please update commit text ("bump golangci to 1.55.2 ..." to 1.55 without ".2").

@dannyzaken dannyzaken merged commit c02857c into noobaa:master Dec 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants