Add upgrade process for postgres DB version 15 #1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
force-pushed
the
upgrade-postgres-db
branch
4 times, most recently
from
dccde47 to
f3a7a25
Compare
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
upgrade-postgres-db
branch
from
f3a7a25 to
c069a52
Compare
jackyalbo
reviewed
Oct 11, 2023
|
|
||
| case nbv1.UpgradePhasePrepare: | ||
|
|
||
| r.Logger.Infof("UpgradePostgresDB phase nbv1.UpgradePhasePrepare") |
There was a problem hiding this comment.
why not take this print out and just print phase variable?
| r.NooBaa.Status.BeforeUpgradeDbImage = &oldImage | ||
| } | ||
|
|
||
| case nbv1.UpgradePhasePrepare: |
There was a problem hiding this comment.
Can you maybe add a general comment about what is done in every phase, and what we expect to find?
2 tasks
|
@jackyalbo Can we close this one? |
|
Closing as a fixed PR clone was already merged: #1264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: