New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed CustomImage event to NooBaaImage event for every image change #105

Merged

guymguym merged 1 commit into noobaa:master from dannyzaken:danny-rgw

Oct 27, 2019

Member

dannyzaken commented Oct 27, 2019

removed event on custom image when not using default image
generate event for creation and every image change


          changed CustomImage event to NooBaaImage event for every image change

7e50343

dannyzaken requested a review from guymguym

October 27, 2019 13:22

guymguym approved these changes

View reviewed changes

guymguym reviewed

View reviewed changes

pkg/system/phase2_creating.go

@@ @@ -162,6 +172,15 @@ func (r *Reconciler) SetDesiredCoreApp() { @@
               				}
               			}
               		}
+              		if coreImageChanged {
+              			// generate info event for the first creation of noobaa

Member

guymguym Oct 27, 2019

fix the comment...

guymguym added this to the v2.0.5 milestone

guymguym merged commit 349879a into noobaa:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet