Changed non-guaranteed to best-effort and description

Signed-off-by: Aayush Chouhan <[email protected]>
noobaa · May 23, 2024 · e3ed863 · e3ed863
1 parent 5bf1285
commit e3ed863
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 16 deletions.
diff --git a/deploy/crds/noobaa.io_noobaas.yaml b/deploy/crds/noobaa.io_noobaas.yaml
@@ -987,10 +987,9 @@ spec:
                   loggingType:
                     description: |-
                       LoggingType specifies the type of logging for the bucket
-                      There are two types available: guaranteed and non-guaranteed logging
-                      - guaranteed logging ensures that all log entries are recorded without fail
-                      - non-guaranteed logging may not record all log entries
-                      By default, non-guaranteed logging is enabled if no type is specified
+                      There are two types available: best-effort and guaranteed logging
+                      - best-effort(default) - less immune to failures but with better performance
+                      - guaranteed - much more reliable but need to provide a storage class that supports RWX PVs
                     type: string
                 type: object
               cleanupPolicy:

diff --git a/pkg/apis/noobaa/v1alpha1/noobaa_types.go b/pkg/apis/noobaa/v1alpha1/noobaa_types.go
@@ -244,10 +244,9 @@ type AutoscalerSpec struct {
 // BucketLoggingSpec defines the configuration for the bucket
 type BucketLoggingSpec struct {
 	// LoggingType specifies the type of logging for the bucket
-	// There are two types available: guaranteed and non-guaranteed logging
-	// - guaranteed logging ensures that all log entries are recorded without fail
-	// - non-guaranteed logging may not record all log entries
-	// By default, non-guaranteed logging is enabled if no type is specified
+	// There are two types available: best-effort and guaranteed logging
+	// - best-effort(default) - less immune to failures but with better performance
+	// - guaranteed - much more reliable but need to provide a storage class that supports RWX PVs
 	// +optional
 	LoggingType BucketLoggingTypes `json:"loggingType,omitempty"`
 
@@ -565,9 +564,9 @@ type BucketLoggingTypes string
 
 // These are the valid BucketLoggingTypes types:
 const (
+	// BucketLoggingTypeNonGuaranteed is best-effort
+	BucketLoggingTypeBestEffort BucketLoggingTypes = "best-effort"
+
 	// BucketLoggingTypeGuaranteed is guaranteed
 	BucketLoggingTypeGuaranteed BucketLoggingTypes = "guaranteed"
-
-	// BucketLoggingTypeNonGuaranteed is non-guaranteed
-	BucketLoggingTypeNonGuaranteed BucketLoggingTypes = "non-guaranteed"
 )
diff --git a/pkg/bundle/deploy.go b/pkg/bundle/deploy.go
@@ -1483,7 +1483,7 @@ spec:
       status: {}
 `
 
-const Sha256_deploy_crds_noobaa_io_noobaas_yaml = "5694859015599e2a0ec2af19249fb4677fd0060ef3c1cb7e706754d7de640ed6"
+const Sha256_deploy_crds_noobaa_io_noobaas_yaml = "650f7c4f4740f3d6ea4ae49a57def282cac049583ee114605dcf8884ef565772"
 
 const File_deploy_crds_noobaa_io_noobaas_yaml = `---
 apiVersion: apiextensions.k8s.io/v1
@@ -2474,10 +2474,9 @@ spec:
                   loggingType:
                     description: |-
                       LoggingType specifies the type of logging for the bucket
-                      There are two types available: guaranteed and non-guaranteed logging
-                      - guaranteed logging ensures that all log entries are recorded without fail
-                      - non-guaranteed logging may not record all log entries
-                      By default, non-guaranteed logging is enabled if no type is specified
+                      There are two types available: best-effort and guaranteed logging
+                      - best-effort(default) - less immune to failures but with better performance
+                      - guaranteed - much more reliable but need to provide a storage class that supports RWX PVs
                     type: string
                 type: object
               cleanupPolicy: