Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add IRSA as first precedent for aws client creds #202

Merged
merged 6 commits into from
Jun 17, 2022

Conversation

prestwich
Copy link
Member

Motivation

Enable usage of a standard creds mechanism. We thought that this was supported by the default credentials provider, but it is not. This was an oversight in our reqs and verification

Solution

  • break global aws client state out into a new nomad_core::aws module
  • add get_client method to instantiate a shared aws Client
  • add get_kms_client method to instantiate a shared KmsClient
  • add WebIdentityProvider as preferred credentials provider for Client instantiation
  • fall back to DefaultCredentialsProvider if WebIdentityProvider fails to return credentials
  • modify processor to use the global Client to instantiate its S3Client

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package

@prestwich prestwich marked this pull request as ready for review June 15, 2022 19:33
@prestwich prestwich force-pushed the prestwich/aws-irsa branch from 935245c to 3fbf3ee Compare June 16, 2022 19:07
Copy link
Collaborator

@luketchang luketchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prestwich prestwich merged commit 0527cb8 into main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants