fix: extra validation on tax params

nolus-protocol · Jan 13, 2025 · b5e9c4e · b5e9c4e
1 parent 00a60d9
commit b5e9c4e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/x/tax/typesv2/params.go b/x/tax/typesv2/params.go
@@ -145,8 +145,12 @@ func validateFeeParams(v interface{}) error {
 	}
 
 	for _, feeParam := range feeParams {
+		err := validateContractAddress(feeParam.ProfitAddress)
+		if err != nil {
+			return errorsmod.Wrap(ErrInvalidFeeParam, err.Error())
+		}
 		if feeParam.ProfitAddress == "" || strings.TrimSpace(feeParam.ProfitAddress) == "" {
-			return ErrInvalidFeeParam
+			return errorsmod.Wrap(ErrInvalidFeeParam, "profit address cannot be blank")
 		}
 		for _, denomPrice := range feeParam.AcceptedDenomsMinPrices {
 			if denomPrice.Denom == "" || strings.TrimSpace(denomPrice.Denom) == "" ||