Add retry after receiving too many requests error from kubernetes
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
force-pushed
the
enh/handle_watch_req
branch
from
1fe0e85 to
2b25997
Compare
|
I'm facing this issue too, and each time, I have to restart the operator to avoid "forgotten" resources. @nolar Any chance you can review this PR ? |
wjsi
force-pushed
the
enh/handle_watch_req
branch
from
2b25997 to
9ce4d5b
Compare
Signed-off-by: Wenjun Si <[email protected]>
wjsi
force-pushed
the
enh/handle_watch_req
branch
from
9ce4d5b to
a499244
Compare
|
@nolar sorry to nag but do you know when we can expect this to be released? |
| if ex.code != HTTP_TOO_MANY_REQUESTS_CODE: | ||
| raise | ||
|
|
||
| retry_wait = ex.details.get("retryAfterSeconds") or DEFAULT_RETRY_DELAY_SECONDS |
There was a problem hiding this comment.
@wjsi quick question - is this key correct? Does APIClientError do some parsing/formatting of the response headers? When we saw this issue our response looked like:
<ClientResponse(https://kubernetes.default.svc/apis/monitoring.coreos.com/v1/namespaces/tenant-sta-cwdev04-added01/servicemonitors/knative-proxy) [429 Too Many Requests]> <CIMultiDictProxy('Cache-Control': 'no-cache, private', 'Content-Type': 'text/plain; charset=utf-8', 'Retry-After': '1', 'X-Content-Type-Options': 'nosniff', 'Date': 'Tue, 14 Mar 2023 16:47:45 GMT', 'Content-Length': '43')>So the response header is just Retry-After in our example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry when receiving HTTP 429 (too many reequests) from k8s when performing
infinite_watch.Fixes #962