Test with extras optionally installed #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
with-3rd-party-clients
branch
from
6401cae to
611acb4
Compare
Signed-off-by: Sergey Vasilyev <[email protected]>
nolar
force-pushed
the
with-3rd-party-clients
branch
from
611acb4 to
f4dc5fa
Compare
Signed-off-by: Sergey Vasilyev <[email protected]>
nolar
changed the title
nolar
force-pushed
the
with-3rd-party-clients
branch
from
9975cdf to
d28fc2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
pykube-ng&kuberneteswere removed as mandatory or CI-only dependencies in #655, the framework also was not tested in its presence. Yet, it started to fail in some tests — e.g. on verbose logging, where we stopped hacking the loggers of those libraries in e40f5d2.Now, with this PR, run the unit-tests in 2 modes: with and without 3rd-party libraries. And fix those tests that were breaking.