Add missing memo kwargs to callback protocols
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Vasilyev <[email protected]>
Specifically: * `callbacks` require `containers` (now: memos) for the kwarg `memo`. * `containers` require `handlers` for `HandlerId` & daemon handler * `handlers` require `callbacks` for callback protocols Previously, it was not a problem because `callbacks` did not declare `memo` kwargs by mistake, and therefore did not import `containers`. The chain is broken at the `callbacks`→`containers` import: it is now `callbacks`→`memos`. Signed-off-by: Sergey Vasilyev <[email protected]>
Signed-off-by: Sergey Vasilyev <[email protected]>
Signed-off-by: Sergey Vasilyev <[email protected]>
Signed-off-by: Sergey Vasilyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
memokwargs to callback protocols and make them part of the public interface (docs, tests).In addition, resolve circular imports:
callbacksrequirecontainers(now:memos) for the kwargmemo.containersrequirehandlersforHandlerId& daemon handler.handlersrequirecallbacksfor callback protocols.Previously, it was not a problem because
callbacksdid not declarememokwargs by mistake, and therefore did not importcontainers.The chain is broken at the
callbacks→containersimport: it is nowcallbacks→memos.