Replace zalando.org → kopf.dev for peering #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peering selectors are modified so that they only select by name (plural name in this case), ignoring the group. As such, both `zalando.org` and `kopf.dev` peerings will be supported (so as any other domains, actually; but the resource name itself implies Kopf, not some other frameworks). This relies on an assumption that *either* `zalando.org` *or* `kopf.dev` peering resources are installed in the cluster, *not both*. It is assumed that both resources cannot co-exist because they share the same names and would cause a conflict anyway. *Compatibility*: The newly configured clusters will use `kopf.dev`, and all is fine. The existing cluster can continue using `zalando.org`, and it will work too (unless reconfigured). *For transitioning*, the old CRD must be removed, and a new CRD must be created. This will wipe all existing peering CRs too, so they must be re-created with the new domain (`kopf.dev`). Applying them with the old domain will fail, as after such a transition, those resources will not exist.
nolar
force-pushed
the
kopf-dev-peering
branch
from
1517d76 to
597cec0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are going to release the next major version, it is time to also make somewhat incompatible changes: use the framework's own identity.
In this part, only the peering is changed. It does affect the runtime. (Related: #643 for docs & examples.)
The peering selectors are modified so that they only select by name (plural name in this case), ignoring the group. As such, both
zalando.organdkopf.devpeerings will be supported (so as any other domains, actually; but the resource name itself implies Kopf, not some other frameworks).This relies on an assumption that either
zalando.orgorkopf.devpeering resources are installed in the cluster, not both. It is assumed that both resources cannot co-exist because they share the same names and would cause a conflict anyway.Compatibility: The newly configured clusters will use
kopf.dev, and all is fine. The existing cluster can continue usingzalando.org, and it will work too (unless reconfigured).For transitioning, the old CRD must be removed, and a new CRD must be created. This will wipe all existing peering CRs too, so they must be re-created with the new domain (
kopf.dev). Applying them with the old domain will fail, as after such a transition, those resources will not exist.