Validate the resource scope against requested namespace #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially, two things: * Cluster-scoped resources cannot have namespaced URLs, even if a namespace is accidentally provided. * Namespace-scoped resources cannot miss the namespace for individual resources (but can miss it for lists). Both cases are considered errors with no fallbacks. It is the caller's responsibility to ensure that the namespace matches the resource's scope. In the framework's code, it serves as an additional validation of the correctness of resource management (observations, orchestration).
nolar
added
automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, two things:
Both cases are considered errors with no fallbacks. It is the caller's responsibility to ensure that the namespace matches the resource's scope. In the framework's code, it serves as an additional validation of the correctness of resource management (observations, orchestration).
Besides, test everything with both namespaced and cluster-scoped resources, to make sure both work fine with all units and aspects — but mostly to make this namespaced vs. cluster-scoped separation work with other tests (previously, there were assumptions on the passed namespace to match the resource's namespace-ability, which hypothetically can be wrong).