Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to support Noir 0.37.0 #16

Merged
merged 8 commits into from
Nov 6, 2024
Merged

feat!: update to support Noir 0.37.0 #16

merged 8 commits into from
Nov 6, 2024

Conversation

kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Oct 24, 2024

Description

fixed the issues with the new release

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kashbrti kashbrti marked this pull request as ready for review October 24, 2024 13:44
@kashbrti
Copy link
Contributor Author

I'm failing to run the formatter. Here's the error I'm getting. It's a bit weird that it panics because I can compile and also the tests pass.

Message:  Expected token Semicolon, got: LeftBracket
Location: tooling/nargo_fmt/src/formatter.rs:194

This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

github-merge-queue bot pushed a commit to noir-lang/noir that referenced this pull request Oct 24, 2024
# Description

## Problem

Resolves
noir-lang/noir_json_parser#16 (comment)

## Summary

I thought for "op assign" like `x += 1` there will always come one or
two tokens, then `=`, but that's not the case for `>>=` (it's `> >=`).

## Additional Context

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@asterite asterite reopened this Oct 25, 2024
@TomAFrench
Copy link
Member

TomAFrench commented Oct 31, 2024

@asterite looks like there's still issues with the formatter Looks like the nightly formatter doesn't panic here so either this code needs to be modified to work on the 0.36.0 formatter or this PR is blocked until we can release 0.37.0

@asterite
Copy link

Right, I made some changes to the formatter after 0.36.0 was released because otherwise it destroyed all the formatting that exists in the array literals here.

@kashbrti
Copy link
Contributor Author

I think it works with nightly just not with 0.36.0. should we just go ahead and merge this?

.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
@TomAFrench
Copy link
Member

It'll need the formatter to be disabled first if we're going to merge without it.

@TomAFrench TomAFrench changed the title feat!: update to support Noir 0.36.0 feat!: update to support Noir 0.37.0 Nov 6, 2024
@TomAFrench TomAFrench merged commit b31c3a7 into main Nov 6, 2024
5 checks passed
@TomAFrench TomAFrench deleted the kb/noir-0.36.0 branch November 6, 2024 10:15
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants