Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format global attributes #7401

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

asterite
Copy link
Collaborator

Description

Problem

Resolves #7397

Summary

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite changed the title Ab/formatter bug global attributes fix: format global attributes Feb 14, 2025
@asterite asterite requested a review from a team February 14, 2025 20:13
@TomAFrench TomAFrench added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit b7ace68 Feb 14, 2025
104 of 105 checks passed
@TomAFrench TomAFrench deleted the ab/formatter-bug-global-attributes branch February 14, 2025 21:14
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 15, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: format global attributes
(noir-lang/noir#7401)
chore: box `Closure` in `comptime::Value` enum
(noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments
(noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum
(noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch
(noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments
(noir-lang/noir#7295)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
AztecBot added a commit to AztecProtocol/aztec-nr that referenced this pull request Feb 18, 2025
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: format global attributes
(noir-lang/noir#7401)
chore: box `Closure` in `comptime::Value` enum
(noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments
(noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum
(noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch
(noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments
(noir-lang/noir#7295)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter panics on compile_success_contract/abi_attribute
2 participants