chore: avoid u128s in brillig memory #7363

TomAFrench · 2025-02-12T22:44:26Z

Description

Problem*

Resolves

Summary*

Currently we store all of our memory as u128s so we need to spend a bunch of time casting between this and smaller types. This PR makes our memory more flexible so that rather than just having a field and integer type (with an internal enum) we have a variant for each supported integer type.

This means that if we have a brillig program which acts exclusively on u8s, then we can maintain those types throughout execution rather than having to constantly cast up and down into u128.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `e900992`	Previous: `97afa52`	Ratio
`AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib`	`242` s	`195` s	`1.24`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

acvm-repo/brillig_vm/src/arithmetic.rs

TomAFrench · 2025-02-13T11:55:31Z

⚠️ Performance Alert ⚠️

I think this is a false positive caused by AztecProtocol/aztec-packages#11897

acvm-repo/brillig_vm/src/arithmetic.rs

acvm-repo/brillig_vm/src/memory.rs

aakoshh

LGTM!

* master: chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361)

chore: update docs about integer overflows (noir-lang/noir#7370) fix!: Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) fix: let LSP read `noirfmt.toml` for formatting files (noir-lang/noir#7355)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: avoid u128s in brillig memory (noir-lang/noir#7363) chore: update docs about integer overflows (noir-lang/noir#7370) fix!: Only decrement the counter of an array if its address has not changed (noir-lang/noir#7297) fix: let LSP read `noirfmt.toml` for formatting files (noir-lang/noir#7355) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>

* master: (42 commits) fix: give "correct" error when trying to use AsTraitPath (#7360) chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361) feat: `FunctionDefinition::as_typed_expr` (#7358) feat(performance): Check sub operations against induction variables (#7356) chore: avoid doing all brillig integer arithmetic on u128s (#7357) feat(cli): Add `--target-dir` option (#7350) fix(ssa): Make the lookback feature opt-in (#7190) feat(performance): Use unchecked ops based upon known induction variables (#7344) chore: mark sha256 as deprecated from the stdlib (#7351) fix: incorrect secondary file in LSP errors (#7347) chore: Basic test for MSM in Noir to catch performance improvements and regressions (#7341) fix(cli): Only lock the packages selected in the workspace (#7345) chore: remove some unused types and functions in the AST (#7339) chore: remove foreign calls array from Brillig VM constructor (#7337) chore(ci): Add Vecs and vecs to cspell (#7342) chore: redo typo PR by osrm (#7238) ...

…rom-brillig * master: chore: allow opting in to displaying benchmark comments (#7399) chore: box `ExprValue` in `Value` enum (#7388) chore: pull out refactored methods from u128 branch (#7385) feat: require safety comments instead of safety doc comments (#7295) fix(ssa): Do not deduplicate division by a zero constant (#7393) chore: document traits required to be in scope (#7387) fix: field zero division in brillig (#7386) chore: box `ParserError`s in `InterpreterError` (#7373) chore: remove unnecessary dereferencing within brillig vm (#7375) fix: give "correct" error when trying to use AsTraitPath (#7360) chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361) feat: `FunctionDefinition::as_typed_expr` (#7358) feat(performance): Check sub operations against induction variables (#7356) chore: avoid doing all brillig integer arithmetic on u128s (#7357)

TomAFrench added 6 commits February 12, 2025 22:44

chore: avoid u128s in brillig memory

adecf4e

.

4b96c5e

.

b056b74

.

2ca96c6

.

85591be

chore: full error handling

4c6f767

TomAFrench marked this pull request as ready for review February 13, 2025 11:20

TomAFrench added 2 commits February 13, 2025 11:21

.

1c9a2b5

.

e900992

TomAFrench requested a review from a team February 13, 2025 11:32

github-actions bot reviewed Feb 13, 2025

View reviewed changes

TomAFrench commented Feb 13, 2025

View reviewed changes

acvm-repo/brillig_vm/src/arithmetic.rs Outdated Show resolved Hide resolved

Merge branch 'master' into tf/brillig-vm-experiments

b742ab1