Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always normalize ssa when priting at least one pass #7299

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

asterite
Copy link
Collaborator

@asterite asterite commented Feb 5, 2025

Description

Problem

If you used --show-ssa-pass it would sometimes crash depending on the program.

Resolves #7235

Summary

I'm not sure why that is the case, but it works fine with --show-ssa which normalized the SSA after every pass. As a quick fix, we now also always normalize the SSA after every pass, but we just print the relevant pass(es) if we are told to do so.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team February 5, 2025 17:37
@aakoshh
Copy link
Contributor

aakoshh commented Feb 5, 2025

Is this related to #7235 in any way?

Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a benign change to me 👍
It would certainly explain why I also experienced problems when printing one pass, but not when all of them are printed, good thinking!

@asterite
Copy link
Collaborator Author

asterite commented Feb 5, 2025

It does seem to resolve #7235, though to be honest I don't know why. Maybe there's a bug when normalizing... though I don't understand why it only happens if we normalize once and not always.

In any case this makes debugging easier for the time being...

@asterite asterite added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit d327462 Feb 5, 2025
72 checks passed
@asterite asterite deleted the ab/always-normalize-when-printing branch February 5, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Consistency Evaluators Errors: aes128_encrypt
2 participants