Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regression test #7195 #7233

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

michaeljklein
Copy link
Contributor

Description

Problem*

Resolves #7207

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

… test of expected trace when stepping through test that was failing in #7195
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 3e80dd5 Previous: d5d6cb7 Ratio
noir-lang_noir_string_search_ 1 s 0 s +∞
noir-lang_noir_bigcurve_ 331 s 275 s 1.20

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@michaeljklein michaeljklein requested a review from a team January 29, 2025 22:53
@michaeljklein michaeljklein changed the title Regression test #7195 chore: regression test #7195 Jan 29, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: b19100f Previous: 6d319af Ratio
global_var_regression_entry_points 0.009 s 0.007 s 1.29

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench
Copy link
Member

TomAFrench commented Jan 29, 2025

Haven't looked at this in depth but we'll also want to make some brillig calls to make sure that we stitch the ACIR and brillig callstacks together properly.

@michaeljklein michaeljklein marked this pull request as draft January 30, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add regression testing to track that callstacks are correct
2 participants