-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: array concat method #7199
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: d161a0d | Previous: 4fe4cc6 | Ratio |
---|---|---|---|
sha256_regression |
0.076 s |
0.051 s |
1.49 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
🚀 Deployed on https://67acc7102229f39afa8a0311--noir-docs.netlify.app |
Co-authored-by: Ary Borenszweig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: c472a26 | Previous: f0ce5c5 | Ratio |
---|---|---|---|
sha256_regression |
1.19 s |
0.934 s |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
FYI @noir-lang/developerrelations on Noir doc changes. |
Description
Add a
concat
method to the stdlib for the array type.Where are the array tests? Where should I put a test for this method? Edit: I've put the test in the same file (despite not seeing tests for the other array methods there)
Problem*
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.