Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove compile_bin_package #4099

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #2608

Summary*

This PR removes the compile_bin_package function as it's pretty unnecessary. At the same time I've added filters to other commands which only make sense on binary packages to avoid #2608

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 2e71444 Jan 22, 2024
31 checks passed
@TomAFrench TomAFrench deleted the tf/remove-compile-bin-package branch January 22, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nargo codegen-verifier fails in any workspace containing library packages
2 participants