chore: provide a canonical "failing" BlackBoxFunctionSolver
#4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
BlackBoxSolverBlackBoxFunctionSolver
kevaundray
approved these changes
Jan 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomAFrench
added a commit
that referenced
this pull request
Jan 13, 2024
* master: feat: add `noir-compiler` checks to `aztec_macros` (#4031) chore: remove unnecessary visibility modifiers from u128 trait impls (#4023) chore(ci): install fixed version of `wasm-pack` in CI (#4034) chore: remove `release-tests` package (#4032) chore(docs): bumping playground version (#4030) fix: allow ast when macro errors (#4005) chore: provide a canonical "failing" `BlackBoxFunctionSolver` (#4028) feat: assert maximum bit size when creating a U128 from an integer (#4024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
We use a dummy implementation of a
BlackboxFunctionSolverin various places. To simplify things I've provided a centralised implementation of aBlackboxFunctionSolverwhich always fails in theblackbox_solvercrate.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.