Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support module attributes #5495

Closed
jfecher opened this issue Jul 11, 2024 · 0 comments · Fixed by #5888
Closed

Support module attributes #5495

jfecher opened this issue Jul 11, 2024 · 0 comments · Fixed by #5888
Assignees
@asterite @jfecher
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 11, 2024 •
edited
Loading

Problem

We currently support running comptime attribute functions when a attribute is placed on a struct, trait, or function.

Happy Case

We should support module-level attributes as well as attributes that apply to submodule declarations, e.g:

#![module_level_attribute]

...

#[submodule_attribute]
module foo { ... }

#[submodule_attribute]
contract bar { ... }

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the enhancement New feature or request label Jul 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 11, 2024
@jfecher jfecher mentioned this issue Jul 11, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
@jfecher
feat: Allow comptime attributes on traits & functions (#5496)
b59a29e 
# Description

## Problem\*

Resolves #5477

## Summary\*

Adds:
- The ability to run `comptime` attribute functions on traits &
functions in the program
- The `TraitDefinition` type
- The `FunctionDefinition` type
- The `Module` type - the only one of the new types which you still
can't run attributes on. See:
#5495. Running these on modules
is a bit more difficult since modules don't have an entry in
`CollectedItems` to run them on. So I'm delaying this for a later PR.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@asterite asterite mentioned this issue Sep 2, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2024
@asterite
feat: module attributes (#5888)
2ca2e5c 
# Description

## Problem

Resolves #5495

## Summary

Pending:
- [ ] Decide whether to keep attributes as String or SecondaryAttribute
in ModuleData
- [ ] Parsing of module attributes is not ideal (it errors on
non-secondary attributes, but I think not all secondary attributes are
valid for modules... but maybe it's fine because struct attributes work
the same way)

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

@jfecher jfecher

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: module attributes noir-lang/noir
2 participants
@asterite @jfecher