Debugger: Handle BrilligCalls in the Debugger #4823
Labels
Comments
|
Thanks for the context @vezenovm, we're looking into it! |
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 24, 2024
# Description ## Problem\* Resolves #4823 With the introduction of the `BrilligCall` opcode to deduplicate the Brillig bytecode instead of inlining it into `Brillig` opcodes, the debugger was not being able to correctly step into the execution of unconstrained functions. ## Summary\* This PR adds support to the Noir debugger to handle the new `BrilligCall` opcodes and allows stepping into unconstrained functions by retrieving the opcodes from the deduplicated Brillig functions. The changes impact both the REPL and the DAP debuggers. ## Additional Context In DAP mode, the disassembly request is still not working properly. It seems that we are not responding to the command in an appropriate manner. We will tackle that problem separately. ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Maxim Vezenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
After this PR AztecProtocol/aztec-packages#5737 which resolves #3907 we now support execution of a
BrilligCallopcode that contains an ID to a Brillig function rather than inlining the Brillig bytecode into the opcode itself. This requires some execution changes that also affect the debugger.cc @ggiraldez @mverzilli
Happy Case
The debugger should support
BrilligCallas it supports working withBrilligright now. Once we fully removeBrilligthe debugger should still work well. A specific location that comes to mind is thestep_into_brillig_opcodewill need to be updated similarly to howsolve_brillig_call_opcodewas updated from thesolve_brillig_opcodemethod. For the most part the execution changes are quite minor, but just that we need to fetch the appropriate Brillig bytecode rather than having it as part of the ACIR opcode itself.Project Impact
Nice-to-have
Impact Context
The debugger will be broken on compiler versions that have switched to BrilligCall execution.
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: