Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brillig: Move 254 bit integer ops into BInaryFieldOp #4544

Closed
fcarreiro opened this issue Mar 13, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5208
Closed

Brillig: Move 254 bit integer ops into BInaryFieldOp #4544

fcarreiro opened this issue Mar 13, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5208
Assignees
@sirasistant
Labels
enhancement New feature or request

Comments

@fcarreiro
Copy link

Problem

Add LT/LTE/IntegerDiv to BinaryFieldOp and stop emmiting BinaryIntOps with bit_size 254.

Happy Case

N/A

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@fcarreiro fcarreiro added the enhancement New feature or request label Mar 13, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 13, 2024
@sirasistant sirasistant self-assigned this Mar 14, 2024
@sirasistant sirasistant mentioned this issue Mar 14, 2024
Merged
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 14, 2024
@sirasistant
feat: New brillig field operations and refactor of binary operations (#…
eb69504 
…5208)

Fixes noir-lang/noir#4544 and
noir-lang/noir#4543
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 14, 2024
AztecBot added a commit that referenced this issue Mar 14, 2024
@AztecBot
feat: New brillig field operations and refactor of binary operations (A…
8c92772 
…ztecProtocol/aztec-packages#5208)

Fixes #4544 and
#4543
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Mar 15, 2024
@sirasistant @AztecBot
feat: New brillig field operations and refactor of binary operations …
c17b4bb 
…(#5208)

Fixes noir-lang/noir#4544 and
noir-lang/noir#4543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: New brillig field operations and refactor of binary operations AztecProtocol/aztec-packages
2 participants
@fcarreiro @sirasistant