Types of some array functions in the docs are incorrect #4172
Labels
Comments
|
Probably worth holding off on this and doing as part of the code snippets refactor. |
|
@TomAFrench My impression was that the code snippets refactor was just related to code snippets compared to this which concerns the pseudo-code of function declarations. The syntax is also correct here, the main issue is some of these functions aren't listing their |
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 26, 2024
# Description ## Problem\* Resolves #4172 ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [x] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
Looking through the array docs: https://noir-lang.org/docs/noir/syntax/data_types/arrays/#sort
Expected Behavior
Each function to have the correct type
Bug
map,fold,reduce,all, andanyare missing theirselfparameters.Other functions before them also use a more explicit
array: [T; N]overself. This is nice since you can see the object type which you can't withself, but confusing because it makes them look like free functions rather than methods. We should decide on a way to distinguish methods from functions in the docs.To Reproduce
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: