Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golden tests for the compiler #3884

Closed
kevaundray opened this issue Dec 19, 2023 · 2 comments
Closed

Add golden tests for the compiler #3884

kevaundray opened this issue Dec 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

These tests will allow us to test compiler error messages as they would be to the user

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Dec 19, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 19, 2023
@jfecher jfecher mentioned this issue Jan 2, 2024
Merged
5 tasks
ludamad added a commit that referenced this issue Jan 8, 2024
@ludamad
chore: noir sync (#3884)
a6289a5 
Needed a bit of a graft here:
- Looked at current commit on noir/.gitrepo, it pointed to 'just nargo
compile' commit, fixed that to actual commit in aztec-packages branch of
noir
- Fixed parent commit
- did git subrepo noir pull and fixed merge conflicts per instructions
- this PR resulted
@gvozdvmozgu
Copy link
Contributor

Have you considered this good framework for it? https://github.com/oli-obk/ui_test

@jfecher
Copy link
Contributor

jfecher commented Feb 7, 2025

We've moved to use more tests directly testing error enum variants as frontend unit tests so this is no longer necessary.

@jfecher jfecher closed this as completed Feb 7, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jfecher @kevaundray @Savio-Sou @gvozdvmozgu