Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Deprecate nested slices #3363

Closed
16 tasks done
vezenovm opened this issue Oct 30, 2023 · 4 comments
Closed
16 tasks done

Epic: Deprecate nested slices #3363

vezenovm opened this issue Oct 30, 2023 · 4 comments
Assignees
Labels
acir-gen enhancement New feature or request ssa

Comments

@vezenovm
Copy link
Contributor

vezenovm commented Oct 30, 2023

Handling for nested slices has already required a good amount of prep work but still has a few more tasks before it can be labelled fully complete.

The current status of nested slices is that a new pass has been introduced that fills nested slices with dummy data so that the internal types match up in size. The fill internal slices pass is necessary to get dynamic nested slices working in ACIR. This is the initial pass (#3258). However, this pass currently only works with one block and needs to be expanded to handle filling of dummy data in flattening. I have made this task list to better track what issues are leftover to complete.

#3187 is the initial work that prompted the fill internal slices pass.

Tasks

Preview Give feedback
  1. bug enhancement ssa
    vezenovm
  2. E-MEDIUM P-HIGH acir-gen enhancement ssa
  3. E-MEDIUM P-HIGH acir-gen enhancement
    vezenovm
  4. brillig bug ssa
    vezenovm
  5. bug
    vezenovm
  6. bug

Ban nested slices tracker:

Tasks

Preview Give feedback
  1. enhancement
    vezenovm
  2. acir-gen enhancement ssa
    vezenovm
  3. enhancement

As per this comment this is a following task list of any remaining slice issues that need to be resolved to state that slices are fully stable:

Tasks

Preview Give feedback
  1. bug
    vezenovm
  2. bug
    guipublic vezenovm
  3. bug
    michaeljklein
  4. bug
    michaeljklein
  5. bug
    jfecher vezenovm

There is also issue #1344 for enabling printing of slices. This would be a more feature update and we might be able to tie into a general refactor of formatting strings in Noir.

@vezenovm
Copy link
Contributor Author

vezenovm commented Jan 11, 2024

After an internal meeting and the complexity introduced in #3979 we have decied to temporarily shelve nested slices. In the main issue a new tracklist has been created to mark their removal.

@kevaundray kevaundray added this to the 0.23.0 milestone Jan 15, 2024
@kevaundray
Copy link
Contributor

Once we merge the ban nested slices PR, can you check the bugs/issues/tasks that are related to slices to see if they are still relevant?

@kevaundray kevaundray modified the milestones: 0.23.0, 0.24.0 Jan 22, 2024
@vezenovm
Copy link
Contributor Author

vezenovm commented Feb 5, 2024

I will leave #528 to be closed once this issue is closed.

@Savio-Sou Savio-Sou changed the title Epic: Nested slices Epic: Deprecate nested slices Feb 8, 2024
@Savio-Sou Savio-Sou removed this from the 0.24 milestone Feb 9, 2024
@vezenovm vezenovm moved this from 📋 Backlog to 🏗 In progress in Noir Feb 15, 2024
@Savio-Sou Savio-Sou assigned michaeljklein and unassigned vezenovm Mar 8, 2024
@vezenovm
Copy link
Contributor Author

Closing this issue now that all tasks have been completed. Any new slice bugs can be separate from this issue.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acir-gen enhancement New feature or request ssa
Projects
Archived in project
Development

No branches or pull requests

4 participants