-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Deprecate nested slices #3363
Comments
After an internal meeting and the complexity introduced in #3979 we have decied to temporarily shelve nested slices. In the main issue a new tracklist has been created to mark their removal. |
Once we merge the ban nested slices PR, can you check the bugs/issues/tasks that are related to slices to see if they are still relevant? |
I will leave #528 to be closed once this issue is closed. |
Closing this issue now that all tasks have been completed. Any new slice bugs can be separate from this issue. |
Handling for nested slices has already required a good amount of prep work but still has a few more tasks before it can be labelled fully complete.
The current status of nested slices is that a new pass has been introduced that fills nested slices with dummy data so that the internal types match up in size. The fill internal slices pass is necessary to get dynamic nested slices working in ACIR. This is the initial pass (#3258). However, this pass currently only works with one block and needs to be expanded to handle filling of dummy data in flattening. I have made this task list to better track what issues are leftover to complete.
#3187 is the initial work that prompted the fill internal slices pass.
Tasks
Ban nested slices tracker:
Tasks
As per this comment this is a following task list of any remaining slice issues that need to be resolved to state that slices are fully stable:
Tasks
map
on a slice panics #4220There is also issue #1344 for enabling printing of slices. This would be a more feature update and we might be able to tie into a general refactor of formatting strings in Noir.
The text was updated successfully, but these errors were encountered: